fix: patch dataloader to propagate context to new fiber #1760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuanduc987
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
xuanduc987
commented
Oct 24, 2025
| end | ||
|
|
||
| def patch | ||
| return if gem_version < Gem::Version.new('2.1.8') |
Contributor
Author
There was a problem hiding this comment.
The target of the patch, Dataloader#spawn_fiber method existed from version 2.1.8
Contributor
There was a problem hiding this comment.
Ideally we would have some automated tests that test this functionality to avoid regressions.
@rmosolgo do you have any recommendations on how to set up a test to cover this?
Contributor
Author
There was a problem hiding this comment.
I had added a test for the expected behavior of #spawn_fiber.
I also confirmed that it failed without the patch.
Contributor
|
cc: @rmosolgo Request for review |
Contributor
|
LGTM 👍 |
arielvalentin
changed the title
xuanduc987
force-pushed
the
push-xqttxrkrtkkz
branch
from
5c864f9 to
9108622
Compare
arielvalentin
approved these changes
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should fix #127